Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in Cordova 3.7.0 #312

Closed
hirbod opened this issue Nov 20, 2014 · 6 comments
Closed

Small bug in Cordova 3.7.0 #312

hirbod opened this issue Nov 20, 2014 · 6 comments
Milestone

Comments

@hirbod
Copy link
Contributor

hirbod commented Nov 20, 2014

Hi Masashi,

just updated to Cordova 3.7.0 (careful people, some ugly bugs with console.log() and memory leaks, stay at 3.6.3 till they patch)

But there is a small problem. On init I receive more then 60 console.log messags with "NULL" and triggered red (as error)

They are invoked here:
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/blob/master/www/googlemaps-cdv-plugin.js#L114

The message is also NULL.

bildschirmfoto 2014-11-20 um 01 05 28

@wf9a5m75
Copy link
Member

It seems this #301

@hirbod
Copy link
Contributor Author

hirbod commented Nov 20, 2014

But it's weird that this error suddently happened on cordova 3.7.0 (iOS8, iPhone 6 Plus and iOS7, iPhone 5)

I updated with remove platform and add platform (had a weird bug before, thats why I did like this)
But as I said, this problem started now, but it seems not to break my app, just looks ugly. Anyway, you should disable console.log there, as it is alway NULL

@wf9a5m75
Copy link
Member

It's Cordova's issue.

@hirbod
Copy link
Contributor Author

hirbod commented Nov 20, 2014

Could you put a

 if(msg) { 
   console.log(msg); 
}

around it? That would at least stop NULLs being throttled to the log

wf9a5m75 added a commit that referenced this issue Nov 20, 2014
wf9a5m75 added a commit that referenced this issue Nov 20, 2014
wf9a5m75 added a commit that referenced this issue Nov 20, 2014
wf9a5m75 added a commit that referenced this issue Nov 20, 2014
wf9a5m75 added a commit that referenced this issue Nov 20, 2014
@wf9a5m75 wf9a5m75 added this to the v1.2.5 milestone Nov 20, 2014
@Set2005
Copy link

Set2005 commented Dec 20, 2014

Not sure if this is related, the map and marker works fine for me, but I am getting following error when build using IOS, not js error but xcode error, any idea?

2014-12-20 18:11:06.372 App[1544:60b] ERROR: null
2014-12-20 18:11:06.372 App[1544:60b] ERROR: null
2014-12-20 18:11:06.372 App[1544:60b] ERROR: null

@hirbod
Copy link
Contributor Author

hirbod commented Jan 29, 2015

so #352 was the problem and this is now fixed correctly. Maybe the patch is unessacary now?

wf9a5m75 added a commit that referenced this issue Mar 1, 2015
wf9a5m75 added a commit that referenced this issue Mar 1, 2015
wf9a5m75 added a commit that referenced this issue Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants