Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers on Android without infoWindow contents still display an infoWindow #87

Closed
stevesims opened this issue May 27, 2014 · 4 comments
Closed
Milestone

Comments

@stevesims
Copy link

I'm setting a marker on my map to show the user's home position, and it's not intended to be clickable to show an infoWindow. On iOS, tapping on that marker does nothing, whereas on Android I get an empty infoWindow appear.

Adding in the following code into the getInfoContents method inside GoogleMaps.java at the top just after the title and snippet values are fetched appears to resolve this issue:

if ((title == null) && (snippet == null)) {
  return null;
}
@wf9a5m75
Copy link
Member

Thank you, could you make a pull request?

@stevesims
Copy link
Author

Sure - can do.

You asked before if I could do pull requests against the "dev" branch - which currently seems to be slightly outdated compared to master, so a pull request against "dev" touches more files than just the one I've changed...

Do you want to update your dev branch first? Or should I do a pull against master? Or is a pull with all the extra changes OK?

@wf9a5m75
Copy link
Member

Could you make the pull request on the master branch for this time?

Mmm, I need to find out some other better way...

@wf9a5m75 wf9a5m75 added this to the v1.1.1 milestone May 27, 2014
@ghost ghost closed this as completed in 2fdfb65 May 29, 2014
@wf9a5m75
Copy link
Member

The version 1.1.1 is released, and this bug fix is included. Thank you for your help.

ghost pushed a commit that referenced this issue Mar 1, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants