-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added settings for watchdogtimer / complete rewrite of remote marker downloads #367
Conversation
avoid Exceptions and memory leaks, much faster download and user experience trough async image request.
Hi Masashi, since you changed my code a bit, you can't merge it. Would you incoporate my watchdog method manually? This would be nice! Then I could install the test version in my app |
Your code is already in the test branch. |
Watchdog not. I had to incoporate it myself after I've installed the test branch |
Nope... not in test branch |
? |
cause it’s annyoing
@wf9a5m75 you ignore me? :( |
No, it's really busy. |
Want to pull app into the store in 3-4 days.. thanks why I'm pushing so much.. sorry |
Thank you for your help @hirbod
Thank you for your help @hirbod |
damn... now you did overwrite your marker edits.. there was old code in my PR |
Revert please and only take the code-part for WatchDog |
and i really don't understand your organizing. masashi_dev, master and test. All the PRs and fixes are mixed or missing or invalid now?! |
Remove the merged code from Marker.m at once.
Removed your code from Marker.m at once. |
I don't really understand. And where is your improved version of my code? |
masashi_dev's code for me , which includes cordova files. Because of many people ask me many things, such as test, new feature, bug fix ... (you may know), I need to do coding in parallel. |
Allright. Cause usally "test" was your branch for "nearly" final. And now I can't use it anymore. Need to wait till you incorporate all the fixes and new things. Hope you realease 1.2.5 today which has all the new improvements |
So is this your final code, isn't it? |
Yeah, everything allright. But you improved the code because of marker. But I see you've merged the correct code to masashi_dev |
This one is correct. And of course the .h file and die generic download function |
Thank you for your help @hirbod
Remove the merged code from Marker.m at once.
Please mention this function in WIKI