Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indoor map events & toggle location button for android #442

Closed
wants to merge 1 commit into from
Closed

indoor map events & toggle location button for android #442

wants to merge 1 commit into from

Conversation

shawnhwei
Copy link
Contributor

I wasn't sure what branch to pull request to, since I've never done this before. Sorry if its the wrong one...

I've been using these additions for a while finally got around to putting them up. The indoor bits exactly match the original API. I would imagine you might want the location button toggle as it's own function but since its weird to access on the Java end (through getUiSettings) I just put it into setMyLocationEnabled.

I don't use the plugin on iOS and I have no experience with objective-c, so the iOS equivalents still need to be added.

…vated, another argument to setMyLocationEnabled to enable or disable the associated button (ALL ANDROID ONLY)
@wf9a5m75
Copy link
Member

Thank you for sending your pull request. I'm busy now, so let me check this later.

wf9a5m75 added a commit that referenced this pull request Mar 19, 2015
@wf9a5m75
Copy link
Member

Thank you for your pull request.
I'm really appreciated for your work.
I will merge your code into the pull_442 branch after I write the code for iOS.
However I modified your code a little.

Regarding of map.setMyLocationEnabled(true, true), I'd like to avoid like that.
Using two boolean parameters is uncleared what the second value is meaning, without reading the document.

But I forgot to implement to change the value for map.getUiSettings().setMyLocationButtonEnabled() at the same time with map.setMyLocationEnabled().
Thank you for pointing out.

In the past code, I provided the options separately (map.setMyLocationEnabled() and map.getUiSettings().setMyLocationButtonEnabled()).
However many developers confused for that.
So I implemented them to one feature, and everyone does not argument for this.

@shawnhwei
Copy link
Contributor Author

Great!

wf9a5m75 added a commit that referenced this pull request Mar 20, 2015
This reverts commit 9db1a77.
wf9a5m75 added a commit that referenced this pull request Mar 20, 2015
wf9a5m75 added a commit that referenced this pull request Mar 20, 2015
…mented #219 by it.

Thank you for sending the grateful pull request, @meetshawn.
You save my time 👍
@wf9a5m75
Copy link
Member

Merge the pull request #442 is merged into the test branch.
Thank you for sending the grateful pull request, @meetshawn.
You save my time 👍

@wf9a5m75 wf9a5m75 closed this Mar 20, 2015
@wf9a5m75 wf9a5m75 added this to the v1.2.5 milestone Mar 20, 2015
@wf9a5m75 wf9a5m75 mentioned this pull request Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants