Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support java expressions in Mapping#conditionExpression #154

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Support java expressions in Mapping#conditionExpression #154

merged 1 commit into from
Oct 20, 2023

Conversation

cofedream
Copy link
Contributor

Add "conditionExpression" missing support

@thunderhook
Copy link
Contributor

thunderhook commented Oct 18, 2023 •
edited
Loading

Hi @cofedream!

Thank you for this contribution. Could you please add tests for this?
It would be enough to add the "conditionExpression" in JavaExpressionInjectionTest everywhere where also "defaultExpression" is used.

Would you also be so kind to change the commit message to "support java expressions in conditionExpression" or something like that? We can also change this when merging if it is too much trouble for you.

Thanks in advance!

@cofedream
Copy link
Contributor Author

Ok, I'll do this in the next few days.

@cofedream cofedream changed the title Update JavaExpressionInjector.java Support java expressions in Mapping#conditionExpression Oct 20, 2023
@thunderhook thunderhook merged commit f1bc5bd into mapstruct:main Oct 20, 2023
1 of 8 checks passed
@filiphr filiphr added this to the 1.7.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cofedream @thunderhook @filiphr