Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match Java expression core implementation #170

Merged

Conversation

hduelme
Copy link
Contributor

@hduelme hduelme commented Dec 17, 2023

@filiphr I changed the implementation to match the core implementation as you suggested in #164. The only difference is that idea needs the \" at the beginning and end of the string.

@filiphr
Copy link
Member

filiphr commented Dec 27, 2023

Thanks @hduelme.

The only difference is that idea needs the \" at the beginning and end of the string.

Indeed, I think it needs that because it does the check on the level outside of the quotes, whereas in Java it is only the string inside.

@filiphr filiphr merged commit cc1be91 into mapstruct:main Dec 27, 2023
6 of 8 checks passed
@filiphr filiphr added this to the 1.7.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants