Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when using source = "." #204

Merged

Conversation

hduelme
Copy link
Contributor

@hduelme hduelme commented Jul 21, 2024

I implemented #203. As suggested for each source parameter a quick fix to replace the source parameter is given.

Copy link
Contributor

@thunderhook thunderhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hduelme! Works great!

Just a nit-pick and a note about an additional test. Thanks in advance!

@hduelme
Copy link
Contributor Author

hduelme commented Jul 22, 2024

@thunderhook thanks for the review. I also added tests if there is no source property and for the case * is not used as a source. In addition I added the missing documentation for the new inspection

@thunderhook thunderhook linked an issue Jul 23, 2024 that may be closed by this pull request
@thunderhook thunderhook merged commit 815011b into mapstruct:main Jul 23, 2024
7 of 9 checks passed
@thunderhook
Copy link
Contributor

Very nice, thanks for implementing it so quickly @hduelme .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a warnig when using source = "."
2 participants