Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix listFonts #1076

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Fix listFonts #1076

merged 1 commit into from
Nov 24, 2023

Commits on Nov 24, 2023

  1. fix: listFonts was broken, missing fonts could not fallback 

    Promise code never worked: listFonts did not wait for fs.stat() to resolve().
This was not evident because late results were still used.

A recent PR made it worse: late results are now ignored.
This manifested for styles with missing fonts, no fallback could be used.

Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
    @Caerbannog
    Caerbannog committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    95fd256 View commit details
    Browse the repository at this point in the history