fix: avoid synchronous calls where possible #1320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were a bunch of
*Sync
calls that were rather easy to convert to promisified ones, either viautil.promisify
or justnode:fs/promises
.There's at least one more place I didn't touch, solely because it would have required refactoring all of
server.js::start
to be async.There are other places left (out of scope of this PR) where e.g. callback async could be converted to promises, etc.