-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simple typeahead search #1335
Conversation
Signed-off-by: Martijn van Exel <m@rtijn.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding custom data attributes to the elements being filtered, so we don't need to traverse the DOM as much :)
Co-authored-by: Aarni Koskela <akx@iki.fi>
Co-authored-by: Aarni Koskela <akx@iki.fi>
Co-authored-by: Aarni Koskela <akx@iki.fi>
@akx haha yes that would be better for sure! |
I think this looks like a nice feature i would merge. |
Signed-off-by: Martijn van Exel <m@rtijn.org>
all done and as promised we are actually filtering on both name and identifier now :) |
Looks nice and clean with |
Thanks for the suggestions! I hope this is ready to merge but please do let me know if you have any additional changes you would like to see. |
Just an FYI, I will try to test this soon so it can be merged. I have just been slammed this week at my real job and haven't had much time to test PRs this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems simple and worked fine in testing.
The one thing I haven't liked about this is how much room the logo + filter take up. one of these days I need to shrink that logo |
Have to agree with you. With a little bit of work the filter element could be made smaller. Honestly I think the entire page could benefit from a tighter layout. Let me think about this a bit. |
This adds a simple typeahead search to the layer and style overview. Useful for instances with a lot of layers!
tgl-480.mov