Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax Node.js compatibility for -light version #410

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Relax Node.js compatibility for -light version #410

merged 1 commit into from
Jan 17, 2020

Conversation

jdesboeufs
Copy link
Contributor

Hello!

tileserver-gl-light works perfectly with Node.js 12 and 13.
This PR relax the field engines.node in its package.json file.

We actually use a tileserver-gl-light fork in French governement digital services, with this improvement :)

Jerome

@klokan
Copy link
Member

klokan commented Jan 17, 2020 •
edited
Loading

Thanks @jdesboeufs for the contribution !

@petrsloup - could you please review / merge?

@klokan klokan requested a review from petrsloup January 17, 2020 12:30
@klokan klokan added this to the v3.0 milestone Jan 17, 2020
@petrsloup petrsloup merged commit caa641c into maptiler:master Jan 17, 2020
@petrsloup
Copy link
Member

Yes, you are right -- the -light version does not have any native dependencies, so the version restriction is unnecessarily strict here. Thanks for the PR!

@jdesboeufs jdesboeufs deleted the relax-light-version-compatibility branch January 17, 2020 15:16
@ubukawa ubukawa mentioned this pull request Dec 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrsloup petrsloup Awaiting requested review from petrsloup

Assignees
No one assigned
Labels
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jdesboeufs @klokan @petrsloup