Streamline Dockerfile for caching and size #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! HTH, |
|
The xvfb-run wrapper script that is included in the Debian xvfb packages takes care of all setup. However, #242 could be a separate issue. Will check that. |
Move package installation to top of file to enable layer caching in Docker. Use multi stage builds to reduce final image size. Ignore everything but essential files when creating Docker build context.
Start Xvfb wrapper in background and wait for the process to complete. Because wait exits immediately when a signal for which a trap has been set, and the signal handler is executed directly after that, we need to wait again for the background processes to actually finish before exiting. The signal handler catches INT and TERM and forwards them to the node process. The return value from the first wait is stored and sent as exit value.
|
Thanks, merged. |
Closed
strikehawk
pushed a commit
to strikehawk/tileserver-gl
that referenced
this pull request
Apr 22, 2021
Streamline Dockerfile for caching and size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use newer base images and modify Dockerfile to allow for better caching and smaller image file size. Simplify entry script and run as a non-root user.