Use center and zoom from style json #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acalcutt
approved these changes
Mar 28, 2023
acalcutt
reviewed
Mar 28, 2023
src/serve_rendered.js
Outdated
| @@ -1374,6 +1374,9 @@ export const serve_rendered = { | |||
| type: 'baselayer', | |||
| }; | |||
| const attributionOverride = params.tilejson && params.tilejson.attribution; | |||
| if (styleJSON.center && styleJSON.zoom) { | |||
| tileJSON.center = styleJSON.center.concat(styleJSON.zoom); | |||
There was a problem hiding this comment.
I was going to merge this, but I had issues when the zoom level was a decimal value.
I figured out if I added a round Math.round aound styleJSON.zoom it fixes the issue
There was a problem hiding this comment.
tileJSON.center = styleJSON.center.concat(Math.round(styleJSON.zoom)); worked
acalcutt
requested changes
Mar 28, 2023
src/serve_rendered.js
Outdated
| @@ -1374,6 +1374,9 @@ export const serve_rendered = { | |||
| type: 'baselayer', | |||
| }; | |||
| const attributionOverride = params.tilejson && params.tilejson.attribution; | |||
| if (styleJSON.center && styleJSON.zoom) { | |||
| tileJSON.center = styleJSON.center.concat(styleJSON.zoom); | |||
There was a problem hiding this comment.
tileJSON.center = styleJSON.center.concat(Math.round(styleJSON.zoom)); worked
acalcutt
approved these changes
Mar 28, 2023
luandro
pushed a commit
to digidem/tileserver-gl
that referenced
this pull request
Mar 29, 2023
* Use center and zoom from style json as default center for tilejson of rendered maps * Round zoom as style spec allows fractional zooms while tilejson spec does not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the center and zoom values from the style json as default for the center in the tilejson of the rendered map. This is especially useful for serveAllStyles where there is no other way to set this values explicitly.