Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static images: Allow styling each path differently #972

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

samuel-git
Copy link
Contributor

@samuel-git samuel-git commented Sep 9, 2023

Each path was rendered with each path style, drawing over the correctly styled path. Now each path gets only rendered once with the specific path style.

This is now possible:
750x250@2x

With this URL:

http://localhost:8080/styles/basic-preview/static/auto/750x250@2x.jpg?path=stroke:yellow|width:2|fill:green|5.9,45.8|5.9,47.8|10.5,47.8|10.5,45.8|5.9,45.8&path=stroke:blue|width:3|fill:red|4.9,44.8|4.9,46.8|9.5,46.8|9.5,44.8|4.9,44.8

Signed-off-by: Samuel Leihkamm <s.leihkamm@gmx.com>
Signed-off-by: Samuel Leihkamm <s.leihkamm@gmx.com>
Copy link
Collaborator

@acalcutt acalcutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally got a chance to test this and it seemed to work good. I tested with you example and examples from the previous PR and they all still seemed to work as expected.

thanks for submitting this.

@acalcutt acalcutt merged commit 02ee629 into maptiler:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants