Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Add prefix to mbtiles, return 204 on no tile #88

Merged
merged 1 commit into from
Aug 29, 2016
Merged

Add prefix to mbtiles, return 204 on no tile #88

merged 1 commit into from
Aug 29, 2016

Conversation

mtfurlan
Copy link

This adds a configuration option for a prefix to the mbtiles, so you can
store the tiles in other locations.

It also changes the no tile found 404 to a 204, as the mapbox team will
be doing:
mapbox/mapbox-gl-js#1800 (comment)

This adds a configuration option for a prefix to the mbtiles, so you can
store the tiles in other locations.

It also changes the no tile found 404 to a 204, as the mapbox team will
be doing:
mapbox/mapbox-gl-js#1800 (comment)
@daliborjanak
Copy link
Collaborator

daliborjanak commented Aug 29, 2016

Looks good. Thanks, but I would like to rename the variable mbtilesPrefix to something better. We are planning to add geopackage support in next days so it could be something like dataPath, dataSource or dataDir. What do you think?

@mtfurlan
Copy link
Author

I would vote for dataSource, or maybe dataDir.

@klokan
Copy link
Member

klokan commented Aug 29, 2016

In our TileServer GL it is called root path - see JSON config at http://tileserver.readthedocs.io/en/latest/config.html

@daliborjanak
Copy link
Collaborator

I'm prefering data*. Root is often used as root of an app. But this variable as to be used also for folder structures - with serving without htaccess...

@klokan
Copy link
Member

klokan commented Aug 29, 2016

dataRoot or dataPath?

@mtfurlan
Copy link
Author

dataRoot would work, it's still clear as to what it does.

@daliborjanak daliborjanak merged commit 682a9ee into maptiler:master Aug 29, 2016
@mtfurlan
Copy link
Author

It's still mbtilesPrefix?

@daliborjanak
Copy link
Collaborator

2ead30d

@mtfurlan
Copy link
Author

Fair enough.
Many thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants