Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style for OMT 3.11 - boundary, water brunnel #72

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

eva-j
Copy link
Contributor

@eva-j eva-j commented Jan 9, 2020

  • do not display parts of water bodies that are under surface (you can check in Paris: 15/48.85613/2.37204)
  • do not display disputed boundary relations in zooms 0-4 (there is Natural Earth data source)

@pathmapper
Copy link
Member

Hi @eva-j,

thanks for your PR.

I think the brunnel filter should also be applied to the waterway layers (waterway_river and waterway_other) because there is still water under the surface visible (Paris area you mentioned). What do you think?

grafik

Regarding the boundaries:
I don't see any boundaries with a claimed_by field in the current tiles. Can you point me to boundaries where this is the case or is this PR for a future change in the tiles?
According to the OMT changelog, relations with claimed_by should be already included in OMT v3.11.

@eva-j
Copy link
Contributor Author

eva-j commented Jan 10, 2020

Hi @pathmapper, thanks for having a look!

I've just added waterway_tunnel layer, hopefully it looks better.
Anyway, the source

    "openmaptiles": {
      "type": "vector",
      "url": "https://api.maptiler.com/tiles/v3/tiles.json?key={key}"

will be updated to v3.11 during the weekend, so the changes will become visible.

style.json Outdated
"source": "openmaptiles",
"source-layer": "waterway",
"filter": ["all", ["==", "brunnel", "tunnel"]],
"layout": {"visibility": "visible"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"layout": {"visibility": "visible"},

Could you please remove this line, it's not needed and we recently cleaned up the style in #61 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ;)

@pathmapper
Copy link
Member

pathmapper commented Jan 10, 2020

@eva-j thanks for adding the waterway_tunnel layer. Makes sense because we are showing currently also the names for subsurface waterways.

The issue I meant is related to this riverbank
https://www.openstreetmap.org/way/236735249#map=18/48.85285/2.36905

I think there is currently no option to hide it, therefore I opened:
openmaptiles/openmaptiles#764

Left one comment regarding a small change, otherwise this PR is good to merge.

@pathmapper
Copy link
Member

updated to v3.11 during the weekend, so the changes will become visible.

This fixed the riverbank issue.

@pathmapper pathmapper merged commit 4a468f3 into maputnik:gh-pages Jan 13, 2020
"type": "line",
"source": "openmaptiles",
"source-layer": "boundary",
"maxzoom": 5,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is maxzoom: 5 correct here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is different source of boundary data in z0-4 (Natural Earth) and then starting z5 (OSM).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants