-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style for OMT 3.11 - boundary, water brunnel #72
Conversation
eva-j
commented
Jan 9, 2020
- do not display parts of water bodies that are under surface (you can check in Paris: 15/48.85613/2.37204)
- do not display disputed boundary relations in zooms 0-4 (there is Natural Earth data source)
Hi @eva-j, thanks for your PR. I think the brunnel filter should also be applied to the waterway layers ( Regarding the boundaries: |
Hi @pathmapper, thanks for having a look! I've just added waterway_tunnel layer, hopefully it looks better.
will be updated to v3.11 during the weekend, so the changes will become visible. |
style.json
Outdated
"source": "openmaptiles", | ||
"source-layer": "waterway", | ||
"filter": ["all", ["==", "brunnel", "tunnel"]], | ||
"layout": {"visibility": "visible"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"layout": {"visibility": "visible"}, |
Could you please remove this line, it's not needed and we recently cleaned up the style in #61 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done ;)
@eva-j thanks for adding the
Left one comment regarding a small change, otherwise this PR is good to merge. |
This fixed the riverbank issue. |
"type": "line", | ||
"source": "openmaptiles", | ||
"source-layer": "boundary", | ||
"maxzoom": 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is maxzoom: 5 correct here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is different source of boundary data in z0-4 (Natural Earth) and then starting z5 (OSM).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, thanks for the explanation.