Add workaround for marazmista/radeon-profile#151 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the PC returns from sleep/hibernation we can enforce restoration of the correct fan control mode by checking if the correct value is set for pwm_enable and restore the value if necessary
marazmista
requested changes
Nov 1, 2020
| // If the PC is sent to sleep (or hibernate) it can happen that PWM is | ||
| // disabled (by the OS..?) and that we have to re-enable it, if needed, | ||
| // after returning from sleep | ||
| static QFile pwmEnableFile(getDriverFiles().hwmonAttributes.pwm1_enable); |
There was a problem hiding this comment.
It can be without static I think
There was a problem hiding this comment.
It could definitely be non-static. But I thought since the file is always the same it would suffice to construct the QFile object once and re-use it after that to gain a bit of performance (because this function is called quite frequently if I'm correct).
But if you prefer to have it non-static it's no problem for me.
To get around the issue that PWM isn't restored after hibernation it's enough to check the pwm_enable file - we don't need to also store the current PWM state into a variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the PC returns from sleep/hibernation we can enforce restoration of
the correct fan control mode by checking if the correct value is set for
pwm_enable and restore the value if necessary