Invert localUrlAccess to fix https://www.npmjs.com/advisories/1095

marcbachmann · May 7, 2021 · c12d697 · c12d697
1 parent 7f054b6
commit c12d697
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/pdf.js b/lib/pdf.js
@@ -36,7 +36,7 @@ function PDF (html, options) {
   if (!this.options.phantomPath) this.options.phantomPath = phantomjs && phantomjs.path
   this.options.phantomArgs = this.options.phantomArgs || []
 
-  if (this.options.localUrlAccess) this.options.phantomArgs.push('--local-url-access=false')
+  if (!this.options.localUrlAccess) this.options.phantomArgs.push('--local-url-access=false')
   assert(this.options.phantomPath, "html-pdf: Failed to load PhantomJS module. You have to set the path to the PhantomJS binary using 'options.phantomPath'")
   assert(typeof this.html === 'string' && this.html.length, "html-pdf: Can't create a pdf without an html string")
   this.options.timeout = parseInt(this.options.timeout, 10) || 30000

diff --git a/test/index.js b/test/index.js
@@ -229,29 +229,29 @@ test('load with cookies js', function (t) {
   })
 })
 
-test('allows local file access with localUrlAccess=true', function (t) {
+test('does not allow localUrlAccess by default', function (t) {
   t.plan(2)
 
   pdf.create(`
     <body>here is an iframe which receives the cookies
       <iframe src="file://${path.join(__dirname, 'multiple-pages.html')}" width="400" height="100"></iframe>
     </body>
-  `, {localUrlAccess: true})
+  `)
   .toBuffer(function (error, buffer) {
     t.error(error)
     const count = buffer.toString().match(/\/Type \/Page\n/g).length
     t.assert(count === 1, 'Renders a page with 1 page as the content is missing')
   })
 })
 
-test('does not allow localUrlAccess by default', function (t) {
+test('allows local file access with localUrlAccess=true', function (t) {
   t.plan(2)
 
   pdf.create(`
     <body>here is an iframe which receives the cookies
       <iframe src="file://${path.join(__dirname, 'multiple-pages.html')}" width="400" height="100"></iframe>
     </body>
-  `)
+  `, {localUrlAccess: true})
   .toBuffer(function (error, buffer) {
     t.error(error)
     const count = buffer.toString().match(/\/Type \/Page\n/g).length