Skip to content

Commit

Permalink
Remove not working DT settings
Browse files Browse the repository at this point in the history
Remove DT settings which do not seem to work on neither on DT/MS nor D-NS models.
  • Loading branch information
mletenay committed Jan 11, 2022
1 parent d787804 commit d52ec47
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 21 deletions.
3 changes: 0 additions & 3 deletions goodwe/dt.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,8 @@ class DT(Inverter):

# Modbus registers of inverter settings, offsets are modbus register addresses
__all_settings: Tuple[Sensor, ...] = (
Timestamp("time", 40313, "Inverter time"),

Integer("shadow_scan", 40326, "Shadow Scan", "", Kind.PV),
Integer("grid_export", 40327, "Grid Export Enabled", "", Kind.GRID),
Integer("grid_export_limit", 40336, "Grid Export Limit", "W", Kind.GRID),
)

def __init__(self, host: str, comm_addr: int = 0, timeout: int = 1, retries: int = 3):
Expand Down
22 changes: 4 additions & 18 deletions tests/test_dt.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,26 +123,12 @@ def test_GW6000_DT_runtime_data(self):
self.assertSensor('xx144', 100, '', data)

def test_GW6000_DT_read_setting(self):
self.loop.run_until_complete(self.read_setting('grid_export_limit'))
self.assertEqual('7f039d900001a195', self.request.hex())

self.loop.run_until_complete(self.read_setting('time'))
self.assertEqual('7f039d790003f1a0', self.request.hex())
self.loop.run_until_complete(self.read_setting('shadow_scan'))
self.assertEqual('7f039d8600014051', self.request.hex())

def test_GW6000_DT_write_setting(self):
self.loop.run_until_complete(self.write_setting('grid_export_limit', 100))
self.assertEqual('7f069d900064adbe', self.request.hex())

self.loop.run_until_complete(self.write_setting('time', datetime(2022, 1, 4, 18, 30, 25)))
self.assertEqual('7f109d79000306160104121e190dfd', self.request.hex())

def test_get_grid_export_limit(self):
self.loop.run_until_complete(self.get_grid_export_limit())
self.assertEqual('7f039d900001a195', self.request.hex())

def test_set_grid_export_limit(self):
self.loop.run_until_complete(self.set_grid_export_limit(100))
self.assertEqual('7f069d900064adbe', self.request.hex())
self.loop.run_until_complete(self.write_setting('shadow_scan', 1))
self.assertEqual('7f069d8600018c51', self.request.hex())


class GW8K_DT_Test(DtMock):
Expand Down

0 comments on commit d52ec47

Please sign in to comment.