[suggestion] example: Use no_std, and delay using embedded-hal #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not make any difference in the concrete example (linux-embedded-hal's delay is implemented in terms of std::thread), but it removes a stone from the path of people who start from the example towards an actual use of embedded hal. (They'll still have to find suitable replacements for env_hal and linux_embedded_hal, but that's the parts that have to be.)
|
Absolutely makes sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not make any difference in the concrete example
(linux-embedded-hal's delay is implemented in terms of std::thread), but
it removes a stone from the path of people who start from the example
towards an actual use of embedded hal. (They'll still have to find
suitable replacements for env_hal and linux_embedded_hal, but that's
the parts that have to be.)
There are obviously many ways in which an example works. I think that this is a slight improvement, but if you disagree, feel free to just close this PR.
(The core::Duration stays in there because the lib uses Duration, and embedded-hal delays don't work with that, see rust-embedded/embedded-hal#59).