Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jQuery error by using a hash with an unrecognized letter #155

Closed
tkawa opened this issue Dec 5, 2017 · 0 comments
Closed

jQuery error by using a hash with an unrecognized letter #155

tkawa opened this issue Dec 5, 2017 · 0 comments
Labels
bug fixed

Comments

@tkawa
Copy link

tkawa commented Dec 5, 2017

When you use a hash, for example #foo=bar
An error occurs:
Uncaught Error: Syntax error, unrecognized expression: #foo=bar

https://github.com/dolce/iziModal/blob/master/js/iziModal.js#L1231
According to RFC3986, some symbols such as !$&= can be used in "fragment" string, but these symbols are invalid as selector expression for jQuery.

(similar to #27)
chrisdevor added a commit to dochub-legacy/iziModal that referenced this issue Dec 14, 2017
@chrisdevor
fixes jquery bug marcelodolza#155
e1d39f6
marcelodolza added a commit that referenced this issue Jan 5, 2018
@marcelodolza
Merge pull request #160 from macroplant/modalHash-fix
3b13d00 
fixes jquery bug #155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkawa @marcelodolza