Add preventing infinity loop

marcingajda · Mar 31, 2024 · 40463f5 · 40463f5
1 parent afc7cd6
commit 40463f5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/index.test.ts b/src/index.test.ts
@@ -79,3 +79,15 @@ test('Alows to pass custom options', (t) => {
   assert.deepEqual(changeEveryCase.dotKeys(input, { split }), output);
   assert.notDeepEqual(changeEveryCase.dotKeys(input), output);
 });
+
+test('Prevents infinity loop', () => {
+  const input = {
+    recursive: {
+      value: {}
+    },
+  };
+
+  input.recursive.value = input;
+
+  assert.throws(() => changeEveryCase.kebabKeys(input), new Error('Maximum level of 1000 reached. Object is probably recursive!'));
+});
diff --git a/src/index.ts b/src/index.ts
@@ -7,7 +7,11 @@ const isObject = (object: unknown): object is Record<string, unknown> => {
 type Formatter<Options> = (input: string, options?: Options) => string;
 
 const changeKeysFactory = <Options extends changeCase.Options = changeCase.Options>(changeCase: Formatter<Options>) => {
-  return function changeKeys(input: unknown, options?: Options): unknown {
+  return function changeKeys(input: unknown, options?: Options, level = 0): unknown {
+    if (level === 1000) {
+      throw new Error('Maximum level of 1000 reached. Object is probably recursive!');
+    }
+
     if (!isObject(input)) {
       return input;
     }
@@ -18,7 +22,7 @@ const changeKeysFactory = <Options extends changeCase.Options = changeCase.Optio
 
     if (Array.isArray(input)) {
       return input.map((item) => {
-        return changeKeys(item, options);
+        return changeKeys(item, options, level + 1);
       });
     }
 
@@ -30,7 +34,7 @@ const changeKeysFactory = <Options extends changeCase.Options = changeCase.Optio
       const value = (input as Record<string, unknown>)[key];
 
       const changedKey = changeCase(key, options);
-      const changedValue = changeKeys(value, options);
+      const changedValue = changeKeys(value, options, level + 1);
 
       result[changedKey] = changedValue;
     });