Skip to content

Commit

Permalink
Bug 1859941 [wpt PR 42619] - Change expectation for invalid/missing s…
Browse files Browse the repository at this point in the history
…hadowRootMode IDL to null, a=testonly

Automatic update from web-platform-tests
Change expectation for invalid/missing shadowRootMode IDL to null

Per the spec discussion:

whatwg/html#5465 (comment)

this changes the expectation for the tests to be:

document.createElement("template").shadowRootMode === ""

rather than === null.

Note that this CL does not change Chromium's behavior, and as such
I cannot check if there are other tests that implicitly also
do a similar check. More tests might need to change once I (or
someone) implements this new behavior in a browser.

Bug: 1379513
Change-Id: I0ea1371d612d524fdecc287f3f1790d601c64982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4954120
Commit-Queue: Mason Freed <masonfchromium.org>
Auto-Submit: Mason Freed <masonfchromium.org>
Reviewed-by: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/main{#1213658}

--

wpt-commits: af6cbc76339f4d2bd67bcee8e1d9b3be879853eb
wpt-pr: 42619

UltraBlame original commit: 36bafbbc0d89633570c02ee499f4ae40db42c4b0
  • Loading branch information
marco-c committed Nov 8, 2023
1 parent 9d6bb98 commit aacde17
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
t.setAttribute('shadowrootmode','OpEn');
assert_equals(t.shadowRootMode,'open','Case insensitive');
t.setAttribute('shadowrootmode','INVALID');
assert_equals(t.shadowRootMode,null,'Invalid values map to null');
assert_equals(t.shadowRootMode,'','Invalid values map to empty string');
t.removeAttribute('shadowrootmode');
assert_equals(t.shadowRootMode,null,'No shadowrootmode attribute maps to null');
assert_equals(t.shadowRootMode,'','No shadowrootmode attribute maps to empty string');
}, 'Shadowrootmode reflection');

test(() => {
Expand Down

0 comments on commit aacde17

Please sign in to comment.