Bug 1410364 - Don't consider opener when calculating IsSecureContext.…

… r=bz, r=dveditz

Per w3c/webappsec-secure-contexts#42, the
section considering the window opener when calculating secure context is
to be dropped. Firefox already uses "isSecureContextIfOpenerIgnored" in
most places as this is the actual behavior we want. This patch aligns
with the upcoming spec changes by ignoring the window opener. We also no
longer have to keep information about whether our opener was secure as
that no longer factors in our calculations.

UltraBlame original commit: 6784a27f54ff76952569067bab6e34c443e48c84

dom/base/nsGlobalWindowInner.cpp

@@ -4862,10 +4862,6 @@ mAddActiveEventFuzzTime
 (
 true
 )
-mIsSecureContextIfOpenerIgnored
-(
-false
-)
 mWasOffline
 (
 false
@@ -12320,30 +12316,6 @@ IsSecureContext
 )
 ;
 }
-bool
-nsPIDOMWindowInner
-:
-:
-IsSecureContextIfOpenerIgnored
-(
-)
-const
-{
-return
-nsGlobalWindowInner
-:
-:
-Cast
-(
-this
-)
--
->
-IsSecureContextIfOpenerIgnored
-(
-)
-;
-}
 void
 nsPIDOMWindowInner
 :
@@ -38861,19 +38833,6 @@ GetWrapperPreserveColor
 )
 ;
 }
-bool
-nsGlobalWindowInner
-:
-:
-IsSecureContextIfOpenerIgnored
-(
-)
-const
-{
-return
-mIsSecureContextIfOpenerIgnored
-;
-}
 already_AddRefed
 <
 External

dom/base/nsGlobalWindowInner.h

@@ -4041,12 +4041,6 @@ IsSecureContext
 )
 const
 ;
-bool
-IsSecureContextIfOpenerIgnored
-(
-)
-const
-;
 void
 GetSidebar
 (
@@ -8204,11 +8198,6 @@ aRequest
 ;
 protected
 :
-bool
-mIsSecureContextIfOpenerIgnored
-:
-1
-;
 /
 /
 Window

dom/base/nsGlobalWindowOuter.cpp

@@ -6008,10 +6008,6 @@ mHadOriginalOpener
 (
 false
 )
-mOriginalOpenerWasSecureContext
-(
-false
-)
 mIsPopupSpam
 (
 false
@@ -9661,17 +9657,6 @@ state
 "
 )
 ;
-if
-(
-aFlags
-!
-=
-SecureContextFlags
-:
-:
-eIgnoreOpener
-)
-{
 hadNonSecureContextCreator
 =
 !
@@ -9683,44 +9668,6 @@ IsSecureContext
 )
 ;
 }
-else
-{
-hadNonSecureContextCreator
-=
-!
-parentWin
--
->
-IsSecureContextIfOpenerIgnored
-(
-)
-;
-}
-}
-else
-if
-(
-mHadOriginalOpener
-)
-{
-if
-(
-aFlags
-!
-=
-SecureContextFlags
-:
-:
-eIgnoreOpener
-)
-{
-hadNonSecureContextCreator
-=
-!
-mOriginalOpenerWasSecureContext
-;
-}
-}
 if
 (
 hadNonSecureContextCreator
@@ -12119,20 +12066,6 @@ global
 "
 )
 ;
-newInnerWindow
--
->
-mIsSecureContextIfOpenerIgnored
-=
-ComputeIsSecureContext
-(
-aDocument
-SecureContextFlags
-:
-:
-eIgnoreOpener
-)
-;
 mCreatingInnerWindow
 =
 false
@@ -15090,20 +15023,6 @@ mHadOriginalOpener
 =
 true
 ;
-mOriginalOpenerWasSecureContext
-=
-aOpener
--
->
-GetCurrentInnerWindow
-(
-)
--
->
-IsSecureContext
-(
-)
-;
 }
 #
 ifdef

dom/base/nsGlobalWindowOuter.h

@@ -6338,11 +6338,6 @@ mHadOriginalOpener
 1
 ;
 bool
-mOriginalOpenerWasSecureContext
-:
-1
-;
-bool
 mIsPopupSpam
 :
 1

dom/geolocation/nsGeolocation.cpp

@@ -5959,7 +5959,7 @@ win
 )
 -
 >
-IsSecureContextIfOpenerIgnored
+IsSecureContext
 (
 )
 )

dom/webidl/Window.webidl

@@ -3724,115 +3724,6 @@ IdleDeadline
 deadline
 )
 ;
-/
-*
-*
-*
-Similar
-to
-|
-isSecureContext
-|
-but
-doesn
-'
-t
-pay
-attention
-to
-whether
-the
-*
-window
-'
-s
-opener
-(
-if
-any
-)
-is
-a
-secure
-context
-or
-not
-.
-*
-*
-WARNING
-:
-Do
-not
-use
-this
-unless
-you
-are
-familiar
-with
-the
-issues
-that
-*
-taking
-opener
-state
-into
-account
-is
-designed
-to
-address
-(
-or
-else
-you
-may
-*
-introduce
-security
-issues
-)
-.
-If
-in
-doubt
-use
-|
-isSecureContext
-|
-.
-In
-*
-particular
-do
-not
-use
-this
-to
-gate
-access
-to
-JavaScript
-APIs
-.
-*
-/
-partial
-interface
-Window
-{
-[
-ChromeOnly
-]
-readonly
-attribute
-boolean
-isSecureContextIfOpenerIgnored
-;
-}
-;
 partial
 interface
 Window