Skip to content

Commit

Permalink
Bug 1924180 [wpt PR 48581] - Rename & refactor invoker commands to re…
Browse files Browse the repository at this point in the history
…flect new spec decisions., a=testonly

Automatic update from web-platform-tests
Rename & refactor invoker commands to reflect new spec decisions.

Invoker commands now live solely on HTMLButtonElement, and have been
dropped from HTMLInputElement. This was discussed and resolved + minuted
in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))

Words must be separated with dashes. This was discussed and resolved +
minuted in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))

"Custom" commands now require a double dash (`--`) prefix. This was
discussed & resolved + minuted in the Jul 25 OpenUI meeting:
openui/open-ui#969 (comment)

In addition, CommandEvent#invoker is now renamed to CommandEvent#source
as discussed and resolved + minuted in Jul 18 WHATNOT meeting:
whatwg/html#10471 (comment))

This CL updates the tests & implementation to follow these changes. The
changes can also be found in the spec PR which reflects this updated
status:

whatwg/html#9841

Bug: 40284894
Change-Id: Iefa91a1736867239a21f8717aee1fcaaa54fdfd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839601
Reviewed-by: Mason Freed <masonfchromium.org>
Reviewed-by: Luke <lwarlowigalia.com>
Commit-Queue: Keith Cirkel <chromiumkeithcirkel.co.uk>
Cr-Commit-Position: refs/heads/main{#1367705}

--

wpt-commits: 5df7a2c02bb50efa0368910fd49242c08def7a5d
wpt-pr: 48581

UltraBlame original commit: 604a5ed051c0566ff7afefe33c36dfef96d6b950
  • Loading branch information
marco-c committed Oct 15, 2024
1 parent c7dafe9 commit bbaac6b
Show file tree
Hide file tree
Showing 16 changed files with 590 additions and 177 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,9 @@
interestaction
"
"
togglepopover
toggle
-
popover
"
)
;
Expand Down Expand Up @@ -782,7 +784,9 @@
interestaction
"
"
togglepopover
toggle
-
popover
"
)
;
Expand Down Expand Up @@ -860,7 +864,9 @@
interestaction
"
"
togglepopover
toggle
-
popover
"
)
;
Expand Down Expand Up @@ -944,7 +950,9 @@
interestaction
"
"
togglepopover
toggle
-
popover
"
)
;
Expand Down Expand Up @@ -1022,7 +1030,9 @@
interestaction
"
"
tOgGlEpOpOvEr
tOgGlE
-
pOpOvEr
"
)
;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@
null
;
let
childEventInvoker
childEventSource
=
null
;
Expand All @@ -298,7 +298,7 @@
null
;
let
hostEventInvoker
hostEventSource
=
null
;
Expand All @@ -325,11 +325,11 @@
.
target
;
childEventInvoker
childEventSource
=
e
.
invoker
source
;
}
{
Expand Down Expand Up @@ -362,11 +362,11 @@
.
target
;
hostEventInvoker
hostEventSource
=
e
.
invoker
source
;
}
{
Expand All @@ -389,7 +389,7 @@
bubbles
:
true
invoker
source
:
slot
composed
Expand Down Expand Up @@ -434,10 +434,10 @@
;
assert_equals
(
childEventInvoker
childEventSource
slot
"
invoker
source
is
child
inside
Expand Down Expand Up @@ -476,10 +476,10 @@
;
assert_equals
(
hostEventInvoker
hostEventSource
host
"
invoker
source
is
retargeted
to
Expand All @@ -496,7 +496,7 @@
shadow
boundaries
retargeting
invoker
source
"
)
;
Expand Down Expand Up @@ -604,6 +604,8 @@
command
=
'
-
-
test
-
command
Expand All @@ -620,7 +622,7 @@
null
;
let
eventInvoker
eventSource
=
null
;
Expand All @@ -647,11 +649,11 @@
.
target
;
eventInvoker
eventSource
=
e
.
invoker
source
;
}
{
Expand Down Expand Up @@ -687,10 +689,10 @@
;
assert_equals
(
eventInvoker
eventSource
host
"
invoker
source
is
host
"
Expand All @@ -702,7 +704,7 @@
shadow
CommandEvent
retargets
invoker
source
to
host
element
Expand Down
Loading

0 comments on commit bbaac6b

Please sign in to comment.