Updating @svgr/core to 6.2.1 enabling the output of an index.tsx + adding react-native example #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o output and index.tsx instead of an index.js file
…dding TS config + removing XMLNS from the transform
marcomontalbano
requested changes
Jan 30, 2022
There was a problem hiding this comment.
Hi @MateusAndrade, very glad to read your appreciation and thanks a lot for this contribution!
I would only add a description with the list of used svgr plugins and then I'll merge it into 4.1.0.
Co-authored-by: Marco Montalbano <marcomontalbano.work@gmail.com>
|
Btw, it looks like the |
|
No problem for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋 Before anything, thank you so much for the work on this cli. 🚀
Following that, I added a small update to
@svgr/coreupdating the version to6.2.1, outputting theindexfile as atsxinstead of anindex.js.Also, I added small example support
react-nativewith Typescript along a transform removing invalid properties that aren;t supported byreact-native-svgWe can look at the changelog here: gregberge/svgr@v6.1.2...v6.2.1