Can't download extracted audio as mp3

[kjames79]

I've tried about all i can think to do. tried different arguments. always results in .opus

[marcopiovanello]

Can you please try this template -o '%(playlist_title)s/%(title)s.%(ext)s' --extract-audio --audio-format mp3?

[kjames79]

That just made a folder called NA and the files inside when downloaded were .webm

…

On Mon, May 20, 2024, 2:45 AM Marco Piovanello ***@***.***> wrote: Can you please try this template -o '%(playlist_title)s/%(title)s.%(ext)s' --extract-audio --audio-format mp3? — Reply to this email directly, view it on GitHub <#152 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABL5LB4QYQ7HMUA6VBLYMCLZDGLX7AVCNFSM6AAAAABH6Y5F36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZG44DCMRWGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[dj3500]

Works for me with template -x -f m4a (makes m4a, not mp3 - this might be easier as m4a is apparently always available as a stream from youtube?).

[lwsrbrts]

This works for me to produce an mp3 with the metadata/ID3 tag populated in most circumstances..

-x --audio-format mp3 --audio-quality 256 --embed-thumbnail --parse-metadata "title:%(title)s" --parse-metadata "uploader:%(album_artist)s" --embed-metadata --no-embed-info-json

[eric2788]

That just made a folder called NA and the files inside when downloaded were .webm
…
On Mon, May 20, 2024, 2:45 AM Marco Piovanello @.> wrote: Can you please try this template -o '%(playlist_title)s/%(title)s.%(ext)s' --extract-audio --audio-format mp3? — Reply to this email directly, view it on GitHub <#152 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL5LB4QYQ7HMUA6VBLYMCLZDGLX7AVCNFSM6AAAAABH6Y5F36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZG44DCMRWGY . You are receiving this because you authored the thread.Message ID: @.>

same, no matter I changed to audio or not, it always using .webm leads that 404 not found. Download it instantly in Archive is the only solution for now.

[eric2788]

@marcopeocchi the problem is here

func (p *Process) GetFileName(o *DownloadOutput) error {
    cmd := exec.Command(
        config.Instance().DownloaderPath,
        "--print", "filename",
        "-o", fmt.Sprintf("%s/%s", o.Path, o.Filename),
        p.Url,
    )
    cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}

    out, err := cmd.Output()
    if err != nil {
        return err
    }

    p.Output.SavedFilePath = strings.Trim(string(out), "\n")
    return nil
}

even I added audio format argument --audio-format mp3, the print --filename still printing xxxxx.webm, better find an alternative approach for this.

[marcopiovanello]

@marcopeocchi the problem is here

func (p *Process) GetFileName(o *DownloadOutput) error {
    cmd := exec.Command(
        config.Instance().DownloaderPath,
        "--print", "filename",
        "-o", fmt.Sprintf("%s/%s", o.Path, o.Filename),
        p.Url,
    )
    cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}

    out, err := cmd.Output()
    if err != nil {
        return err
    }

    p.Output.SavedFilePath = strings.Trim(string(out), "\n")
    return nil
}

even I added audio format argument --audio-format mp3, the print --filename still printing xxxxx.webm, better find an alternative approach for this.

It's indeed the GetFileName func :(
I'll try to come with a solution but in this time period I'm a little busy.

[eric2788]

@marcopeocchi the problem is here

func (p *Process) GetFileName(o *DownloadOutput) error {
    cmd := exec.Command(
        config.Instance().DownloaderPath,
        "--print", "filename",
        "-o", fmt.Sprintf("%s/%s", o.Path, o.Filename),
        p.Url,
    )
    cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}

    out, err := cmd.Output()
    if err != nil {
        return err
    }

    p.Output.SavedFilePath = strings.Trim(string(out), "\n")
    return nil
}

even I added audio format argument --audio-format mp3, the print --filename still printing xxxxx.webm, better find an alternative approach for this.

It's indeed the GetFileName func :(
I'll try to come with a solution but in this time period I'm a little busy.

I have forked with a solution that extacting the final output from progress log, you can check if it's suitable to you 😀
eric2788@f6cda25

[marcopiovanello]

Thank you so much! Seems pretty solid!