Breadcrumbs for page navigation #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagueame
changed the title
marcoroth
requested changes
Oct 21, 2023
There was a problem hiding this comment.
Hey @divagueame, thanks for working on this!
I like where this is headed! I left some comments, but overall this is very good overall!
|
Thanks for the feedback! I tried to adjust the PR accordingly. Let me know what you think. |
|
Hey @divagueame, sorry. Would you mind reopening this PR |
|
I could not reopen, so just made it here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this an implementation of breadcrumbs. It allows to pass a custom breadcrumb for a page, or to use the already defined title.
Also added a basic README, with the steps I followed to run the project on my machine. Something basic, but it worked for me.