-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement sitemap generation using the 'sitemap_generator' gem #52
Implement sitemap generation using the 'sitemap_generator' gem #52
Conversation
This commit adds sitemap generation for our Sitepress-enabled app. It iterates through all PageModel instances, adding their paths to the sitemap with appropriate change frequencies and priorities. The sitemap helps improve SEO by providing search engines with structured access to our site's pages.
Hi @marcoroth, this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Thank you @joancodes! I just two small things, otherwise this looks good to me
- Ran 'rake sitemap:refresh' to regenerate sitemaps
Hi @marcoroth, I have made the necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for working on this @joancodes! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Google ignores priority and changefreq values. Google uses the lastmod value if it's consistently and verifiably (for example by comparing to the last modification of the page) accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gismoog! Do you have an idea how to properly implement this? It seems like the lastmod
defaults to Time.now
(at the time when the sitemap was generated).
It least this is how it looks in the current sitemap.xml.gz
:
Notable Changes
Issue #47
Screenshots (Optional)
Todo