add pin/unpin command #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snwzd
force-pushed
the
feat/pin_unpin
branch
from
61de57b
to
47781e6
Compare
|
I think pin/unpin is done for binaries, please tell me if there is anything that I should change. |
|
Probably related//solving to #177 too 🤔 ? |
marcosnils
reviewed
Jul 28, 2024
pkg/config/config.go
Outdated
| @@ -35,6 +35,7 @@ type Binary struct { | |||
| // the package path in config so we don't ask the user to select | |||
| // the path again when upgrading | |||
| PackagePath string `json:"package_path"` | |||
| Pin bool `json:"pin"` | |||
|
@snwzt I was coming back to |
marcosnils
reviewed
Jul 28, 2024
cmd/pin.go
Outdated
|
|
||
| binaryList := make(map[string]*config.Binary) | ||
| for _, b := range cfg.Bins { | ||
| binaryList[b.RemoteName] = b |
There was a problem hiding this comment.
This should use getBinPath similar to update here
Line 58 in 91ae3e6
pin can be called either by the binary name or the path.
marcosnils
reviewed
Jul 28, 2024
cmd/unpin.go
Outdated
|
|
||
| binaryList := make(map[string]*config.Binary) | ||
| for _, b := range cfg.Bins { | ||
| binaryList[b.RemoteName] = b |
There was a problem hiding this comment.
marcosnils
reviewed
Jul 28, 2024
cmd/update.go
Outdated
| @@ -59,6 +59,9 @@ func newUpdateCmd() *updateCmd { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if cfg.Bins[bin].Pin { | |||
There was a problem hiding this comment.
Print an info message here instead of returning an error is better as otherwise, this will interrupt the whole update process.
|
Hi, I’ve rebased the branch and made the requested changes. Please tell me if there's anything that I should change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #126