fix incompatiblites to l20n's beta 1 version #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here was the error:
We were using 0.0.11 with installed dependency of L20n@4.0.0-alpha.3. Since it has now changed to beta 1, there is a breaking change in the
ctx.format()
method.It would always return its arguments in the correct object shape that react-l20n-u was expecting (
{messages,errors}
). But now, if only a string was passed andprops
wasnull
, it would just return the string received.So I tried escaping that part of the
getRaw()
method and just return the string that was found.Hope this helps!
Best Regards