Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incompatiblites to l20n's beta 1 version #1

Closed
wants to merge 2 commits into from
Closed

fix incompatiblites to l20n's beta 1 version #1

wants to merge 2 commits into from

Conversation

krassdanke
Copy link

@krassdanke krassdanke commented Feb 13, 2017

So here was the error:
We were using 0.0.11 with installed dependency of L20n@4.0.0-alpha.3. Since it has now changed to beta 1, there is a breaking change in the ctx.format() method.
It would always return its arguments in the correct object shape that react-l20n-u was expecting ({messages,errors}). But now, if only a string was passed and props was null, it would just return the string received.
So I tried escaping that part of the getRaw() method and just return the string that was found.

Hope this helps!
Best Regards

@marcselman
Copy link
Owner

Hi Daniel,

Thanks for checking out my package and contributing.
I'll try to have this fixed somewhere this week.

Feel free to also let me know what features you'd like to see added in the future.

@marcselman
Copy link
Owner

I've updated the package to 0.0.12 to support the Beta 1 version.
The specific characters that were replaced was because of a bug in l20n: l20n/l20n.js#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants