Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new getCountry() method to Iban, Bic and CreditorIdentifier #149

Closed
marcwrobel opened this issue Jul 20, 2022 · 0 comments · Fixed by #151
Closed

Add a new getCountry() method to Iban, Bic and CreditorIdentifier #149

marcwrobel opened this issue Jul 20, 2022 · 0 comments · Fixed by #151
Labels
enhancement

Comments

@marcwrobel
Copy link
Owner

Currently it is not possible to get the IsoCountry from an IBAN, a BIC or a Creditor Identifier. You have to get the country code and then use IsoCountry.fromAlpha2Code().

This is not user-friendly, we should add a new method, getIsoCountry(), in Iban, Bic and CreditorIdentifier.
@marcwrobel marcwrobel changed the title Add a getIsoCountry() in Iban, Bic and CreditorIdentifier. Add a getIsoCountry() in Iban, Bic and CreditorIdentifier Jul 20, 2022
@marcwrobel marcwrobel changed the title Add a getIsoCountry() in Iban, Bic and CreditorIdentifier Add a getCountry() in Iban, Bic and CreditorIdentifier Jul 20, 2022
@marcwrobel marcwrobel changed the title Add a getCountry() in Iban, Bic and CreditorIdentifier Add a new getCountry() method to Iban, Bic and CreditorIdentifier Jul 20, 2022
marcwrobel added a commit that referenced this issue Jul 20, 2022
@marcwrobel
Add a new getCountry() method to Iban, Bic and CreditorIdentifier (cl…
b3ce692 
…oses #149)
@marcwrobel marcwrobel linked a pull request Jul 20, 2022 that will close this issue
Add a new getCountry() method to Iban, Bic and CreditorIdentifier (closes #149) #151
Merged
marcwrobel added a commit that referenced this issue Jul 20, 2022
@marcwrobel
Add a new getCountry() method to Iban, Bic and CreditorIdentifier (cl…
d26ae3a 
…oses #149)
marcwrobel added a commit that referenced this issue Jul 20, 2022
@marcwrobel
Merge pull request #151 from marcwrobel/149-getcountry
4a893b8 
Add a new getCountry() method to Iban, Bic and CreditorIdentifier (closes #149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a new getCountry() method to Iban, Bic and CreditorIdentifier (closes #149) marcwrobel/jbanking
1 participant
@marcwrobel