Paging based on 'continue' links #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed arbitrary exclusion of links over 25 characters long. This seems contradictory to the weighting approach and isn't necessary for any of the test cases.
Adds constructor overloads in NReadabilityWebTranscoder to enable changing the page separator from the default.
Conflicts: NReadability.build NReadability.nuspec Src/NReadability/NReadability.Console/Properties/AssemblyInfo.cs Src/NReadability/NReadability.Tests/NReadability.Tests.csproj Src/NReadability/NReadability.Tests/NReadabilityWebTranscoderTests.cs Src/NReadability/NReadability.Tests/Properties/AssemblyInfo.cs Src/NReadability/NReadability.Tests/SampleWebInput/SampleInput_09_1.html Src/NReadability/NReadability.Tests/SampleWebInput/SampleInput_09_2.html Src/NReadability/NReadability/NReadability.csproj Src/NReadability/NReadability/NReadabilityTranscoder.cs Src/NReadability/NReadability/NReadabilityWebTranscoder.cs Src/NReadability/NReadability/Properties/AssemblyInfo.cs Src/NReadability/NReadability/UrlFetcher.cs Manually merged changes from marek-stoj/NReadability
Links containing the word 'continue' usually imply a context of the current page/article, so they're given a higher weight. All current tests pass; new test added to cover this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 154a8bc adds logic in paging heuristic for heavy weighting on the word "continue".
All existing tests pass, new passing test added to cover that scenario. Example article from http://www.ilr.cornell.edu/trianglefire/story/introduction.html.
Ignore the other commits in this Pull Request, they've all been submitted/reviewed previously.