[BEAM-4294] Join operator translator #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplication of windowing in JoinTranslator fixed.
10 tasks
| c.output(Pair.of(key, outCollector.get())); | ||
| } | ||
| } | ||
| } else if (leftHasValues && !rightHasValues) { |
There was a problem hiding this comment.
!rightHasValues is always true, you can delete it
There was a problem hiding this comment.
Fixed in seznam@013b078 This pull request will be closed.
| joiner.apply(leftValue, null, outCollector); | ||
| c.output(Pair.of(key, outCollector.get())); | ||
| } | ||
| } else if (!leftHasValues && rightHasValues) { |
There was a problem hiding this comment.
!leftHasValues is always true, you can delete it
There was a problem hiding this comment.
Fixed in seznam@013b078 This pull request will be closed.
| K key = element.getKey(); | ||
|
|
||
| Iterable<LeftT> leftSideIter = value.getAll(leftTag); | ||
| Iterable<RightT> rightSIdeIter = value.getAll(rightTag); |
There was a problem hiding this comment.
Fixed in seznam@013b078 This pull request will be closed.
|
This pull request is replaced by #seznam#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation of Euphoria Join suite operators (Inner, Left, Right, Full) into beam transformations. Implementation is centered around
JoinTranslatorwhich defines all the translation steps. And implementations ofJoinFnwhich do the actual join on co-gruped elements, inspiration was drawn fromorg.apache.beam.sdk.extensions.joinlibrary.Join.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue../gradlew buildto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.