Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4360] Migration of ReduceByKey test suite #3

Closed
wants to merge 7 commits into from

Conversation

VaclavPlajt
Copy link
Collaborator

@VaclavPlajt VaclavPlajt commented May 18, 2018

Existing tests suit for ReduceByKey Euphoria operator was adapted for current state of Beam integration. Some tests are ignored due to not yet supported features.

There are still some open points:

  • Flipping test. When whole test suit runs some test may randomly fail. Assertion error shows empty test output. Current believe is that we may have a problem somewhere around ListDataSink due to a race condition. We should address that in https://issues.apache.org/jira/browse/BEAM-4366.
  • Sorting of values. It is not yet clear how to implement this feature in beam.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@VaclavPlajt
Copy link
Collaborator Author

VaclavPlajt commented May 21, 2018

This pull request is replaced by #seznam#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant