Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing any model prop value throws uncaught Error helper.isWorkletSahredValue is not a function #242

Closed
bidah opened this issue Jul 22, 2024 · 4 comments · Fixed by #247
Closed

changing any model prop value throws uncaught Error helper.isWorkletSahredValue is not a function #242

bidah opened this issue Jul 22, 2024 · 4 comments · Fixed by #247
Labels
bug Something isn't working

Comments

@bidah
Copy link

bidah commented Jul 22, 2024 •
edited
Loading

reproducible example: https://github.com/bidah/react-native-filament-testing-app

*This setup is using Expo.

The screen is rendering as expected but upon changing any model prop value like rotate the error shows but if dismissed the change has been applied to the model.

Filament Error: 0,_helper.isWorkletSharedValue is not a function (it is undefined), js engine: Filament

CleanShot 2024-07-22 at 12 06 50
@hannojg hannojg added the bug Something isn't working label Jul 23, 2024
@hannojg
Copy link
Member

hannojg commented Jul 23, 2024

Thanks for the reproduction, checking now!

hannojg added a commit that referenced this issue Jul 23, 2024
@hannojg
fix: #242 exported worklet functions are undefined
6f060b9
@hannojg hannojg mentioned this issue Jul 23, 2024
Merged
@hannojg
Copy link
Member

hannojg commented Jul 23, 2024 •
edited
Loading

This should be fixed in https://github.com/margelo/react-native-filament/releases/tag/v1.5.1

The version will be online in ~5min - can you confirm its fixed?

@hannojg
Copy link
Member

hannojg commented Jul 23, 2024

Tested the new version in your reproduction app - looks like its fixed!

@bidah
Copy link
Author

bidah commented Jul 23, 2024

working! thanks @hannojg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #242 exported worklet functions are undefined margelo/react-native-filament
2 participants
@bidah @hannojg