-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed unexpected blocking in async codepaths w/SSL and other issues #216
Open
jtrberg
wants to merge
9
commits into
mariadb-corporation:3.3
Choose a base branch
from
jtrberg:3.3-jtrberg
base: 3.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtrberg
commented
Jan 10, 2023
- unexpected thread blocking in async codepath (https://jira.mariadb.org/browse/CONC-594)
- disabled 0s timeouts not handled correctly
- pvio double free if async connect fails
- invalid usage of 0.0.0.0 IP by test_conc622 to test conn failure. Conn can unexpectedly succeed when server/client are co-located on same host.
- reduced # of iterations of test_conc622
(https://jira.mariadb.org/browse/CONC-594) - disabled 0s timeouts not handled correctly - pvio double free if async connect fails
This reverts commit da7c706.
…e. Conn can unexpectedly succeed when server/client are colocated on host.
I have managed to address issues found in async.c unit test, but I see that there is also a failing test in connection.c: its called: test_auth256 https://app.travis-ci.com/github/mariadb-corporation/mariadb-connector-c/jobs/592897472
When I run this test locally on a branch with my changes it passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.