Fix maxscale production parser (refs FRUC-194) #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amvasilyev
requested changes
Dec 26, 2024
| maxscale_ci: | ||
| repo: | ||
| path: https://mdbe-ci-repo.mariadb.net/Maxscale/ | ||
| old_key: https://mdbe-ci-repo.mariadb.net/MariaDBManager-GPG-KEY.public | ||
| new_key: https://mdbe-ci-repo.mariadb.net/MDBE.public | ||
| no_sublinks: false |
There was a problem hiding this comment.
Double negation is hard to read and reason.
Please switch from using Boolean values to usage of enumerations. I.e. user must declare a scan mode:
- follow-only-sublinks
- use-all-links
This data must be put inside the documentation for repository configuration.
| @@ -217,17 +217,17 @@ def parse_repository( | |||
| *steps | |||
| ) | |||
| # Recursively go through the site and apply steps on each level | |||
| result = parse_web_directories(base_url, auth, product_version, log, logger, *steps) | |||
| result = parse_web_directories(base_url, auth, product_version, false, log, logger, *steps) | |||
There was a problem hiding this comment.
Why false constant is applicable here?
…supported products (refs FRUC-194)
…ning mode description (refs FRUC-194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.