-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind Evaluator interface to pymarian #1013
Conversation
- readme with usage instructions - add executables: mtapi, qtdemo, evaluate - rename binding package as _pymarian to avoid conflicts with "pymarian" package
@mjpost updated instructions for testing these changes. |
add note on experimental API
There seems to be a problem with multi-gpu usage with pymarian. How to reproduce: terminal2: watch usage: |
Fixed it. Since there is no iterator support at the mment, we have minibatches made in python (to avoid buffering all scores in memory and the waiting until the end). |
efd9cd1
to
7ba76eb
Compare
Closing since we have merged these changes in Azure DevOps fork! |
Description
List of changes:
replaced skbuild with skbuild-core, the next gen build system. replaced setup.py with pyproject.toml (setup.py is deprecated)
Revised pymarian code and added evaluator interface. split pymarian.h -> translator + evaluator .hpp files
Add BufferedVectorCollector to access scores in memory without i/o
Reorg pymarian dir into tests and examples
add evaluator example script that downloads metrics from our blob storage (publicly accessible)
configured CLI executables: pymarian-evaluate, pymarian-qtdemo, pymarian-mtapi
Added dependencies: none
How to test
These instructions are added to README in src/python.
Example Usage
mtapi
Launch server
Example request from client
QtDemo
Checklist