quote CPUINFO in cmake #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these quotes, cmake fails in a confusing manner on systems whose cpuinfo output includes spaces. This arose in the context of attempting to compile natively on an m1 mac. $ /usr/sbin/sysctl -n machdep.cpu.features machdep.cpu.leaf7_features sysctl: unknown oid 'machdep.cpu.leaf7_features' Obviously, this didn't work out well; there is still much more to do. Still, the quotes are cheap and eliminate a confusing failure mode. For this reason, I added them to the linux as well as the darwin path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these quotes, cmake fails in a confusing manner on systems whose cpuinfo output includes spaces.
This arose in the context of attempting to compile natively on an m1 mac.
Obviously, this didn't work out well; there is still much more to do. Still, the quotes are cheap and eliminate a confusing failure mode in favor of the real problem. For this reason, I added them to the linux as well as the darwin path.
Added dependencies: none
How to test
Run cmake. Observe that nothing has changed.
Checklist