Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptive Notation to Algebraic Notation conversion failure #1

Closed
insanetesterftw opened this issue Feb 17, 2017 · 2 comments
Closed

Comments

@insanetesterftw
Copy link

Trying to convert to convert the example presented on this Wikipedia article Example fails.

At this point:

  1. ... BxNP

It also fails in others cases like PxBP.

@marianogappa
Copy link
Owner

Thank you for reviewing this case! I will probably have time to look into this no sooner than this weekend; sorry.

@marianogappa
Copy link
Owner

@insanetesterftw got the wikipedia example you mentioned working except for one detail: it can't deal with checks, doublechecks and mates being separated from the moves (by spaces).

This should now work

1. P-K4 P-K4
2. N-KB3 N-QB3
3. B-B4 B-B4
4. P-QN4 BxNP
5. P-B3 B-R4
6. P-Q4 PxP
7. O-O P-Q6
8. Q-N3 Q-B3
9. P-K5 Q-N3
10. R-K1 KN-K2
11. B-R3 P-N4
12. QxP R-QN1
13. Q-R4 B-N3
14. QN-Q2 B-N2?
15. N-K4 Q-B4?
16. BxQP Q-R4
17. N-B6ch! PxN
18. PxP R-N1
19. QR-Q1! QxN
20. RxNch NxR
21. QxPch! KxQ
22. B-B5dblch K-K1
23. B-Q7ch K-B1
24. BxNmate

http://marianogappa.github.io/ostinato-examples/parser

Let me know what you find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants