Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve <Button> and use react-aria #1183

Closed
ti10le opened this issue Jul 16, 2021 · 0 comments · Fixed by #1182
Closed

Improve <Button> and use react-aria #1183

ti10le opened this issue Jul 16, 2021 · 0 comments · Fixed by #1182
Assignees
@ti10le
Labels
status:ready Ready for development type:docs Improvements or additions to documentation type:feature New feature or component

Comments

@ti10le
Copy link
Contributor

ti10le commented Jul 16, 2021

Description
Our Button component doesn't work like he should. We make them polymorphic and improve the accessibility (react-aria).
https://react-spectrum.adobe.com/react-aria/useButton.html

Context
We want to have a Button component which works correctly and is complete accessible.

Consequences
Easier and better usage of Button component. Good accessibility!
@ti10le ti10le added the status:rfc New issue that requires discussion and finalization label Jul 16, 2021
@ti10le ti10le self-assigned this Jul 16, 2021
@ti10le ti10le added status:ready Ready for development type:docs Improvements or additions to documentation type:feature New feature or component and removed status:rfc New issue that requires discussion and finalization labels Jul 16, 2021
@ti10le ti10le mentioned this issue Jul 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ti10le ti10le

Labels
status:ready Ready for development type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve Button component with react-aria marigold-ui/marigold
1 participant
@ti10le