Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Button component with react-aria #1182

Merged
merged 2 commits into from
Jul 19, 2021
Merged

improve Button component with react-aria #1182

merged 2 commits into from
Jul 19, 2021

Conversation

ti10le
Copy link
Contributor

@ti10le ti10le commented Jul 15, 2021

closes #1183

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2021

🦋 Changeset detected

Latest commit: 9a2ad28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@marigold/components Patch
docs Patch
@marigold/icons Patch
@marigold/theme-b2b Patch
@marigold/theme-unicorn Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the type:feature New feature or component label Jul 15, 2021
@coveralls
Copy link

coveralls commented Jul 15, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 9a2ad28 on improve-button-aria into c325f71 on main.

@ti10le ti10le marked this pull request as draft July 15, 2021 13:39
@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Jul 16, 2021
@ti10le ti10le force-pushed the improve-button-aria branch from e75d556 to 2733053 Compare July 19, 2021 09:19
@ti10le ti10le marked this pull request as ready for review July 19, 2021 13:35
Copy link
Member

@sebald sebald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍👍

@sebald sebald merged commit f3f6145 into main Jul 19, 2021
@sebald sebald deleted the improve-button-aria branch July 19, 2021 16:30
sebald added a commit that referenced this pull request Jul 26, 2021
* main:
  fix(deps): update storybook monorepo to v6.3.5 (#1192)
  chore(deps): update all (#1194)
  fix(deps): update typescript-eslint monorepo to v4.28.4 (#1193)
  fix(system): List reset should not remove the enumeration (#1190)
  chore: Fix broken changeset (#1191)
  improve Button component with react-aria (#1182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve <Button> and use react-aria
3 participants