Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design & component update - Select #913

Closed
ti10le opened this issue Apr 9, 2021 · 9 comments
Closed

Design & component update - Select #913

ti10le opened this issue Apr 9, 2021 · 9 comments
Assignees
Labels
status:ready Ready for development type:design design type:feature New feature or component

Comments

@ti10le
Copy link
Contributor

ti10le commented Apr 9, 2021

Current Version:

  • simple Select component with variant prop

-> Figma Design

Todo:

  • show select as expected in the figma design
  • add error prop to make outline red and show Validation Message
  • add focused and disabled
  • add hover and selected
@ti10le ti10le added type:design design type:feature New feature or component labels Apr 9, 2021
@ti10le ti10le changed the title Design update - Select Design & component update - Select Apr 12, 2021
@ti10le ti10le added the status:rfc New issue that requires discussion and finalization label Apr 13, 2021
@ti10le ti10le added status:ready Ready for development and removed status:rfc New issue that requires discussion and finalization labels Apr 26, 2021
@ti10le
Copy link
Contributor Author

ti10le commented Jul 9, 2021

first changes for this issue in #1146

@ti10le
Copy link
Contributor Author

ti10le commented Jul 20, 2021

ToDo:

  • Item defaultSelected
  • Item disabled
  • show select as expected in the figma design: borders when open listBox, button and listbox every time the same width
  • error prop to show error like in the figma design
  • required prop to show error like in the figma design

@ti10le
Copy link
Contributor Author

ti10le commented Jul 28, 2021

  • error and required prop --> in review
  • itemSelected and disabledItem --> almost finished

@viktoria-schwarz
Copy link
Contributor

  • The select field "jumps" when you open it (border instead of outline)
  • If you open the dropdown on the bottom of the page and the ListBox is displayed above, the borders are wrong
  • What if you want to unselect an item/select "none"? (display placeholder as option, optionally)
  • on error: doesn't it make more sense to remove the red border when listbox is opened and only display the red border when the focus is NOT on the select?
  • use <Select> on docs page for ThemeSwitch

@ti10le @sebald what do you think, how close should we stick to the Figma design?

@sebald
Copy link
Member

sebald commented Jul 29, 2021

As close as possible? 😄

@viktoria-schwarz
Copy link
Contributor

Well :D I find it difficult if it doesn't cover all cases, but fine

@sebald
Copy link
Member

sebald commented Jul 30, 2021

Yeah, I mean we should get 100%!

@ti10le
Copy link
Contributor Author

ti10le commented Aug 16, 2021

fix todo: styling if select listbox opens above the select button.

@ti10le
Copy link
Contributor Author

ti10le commented Aug 23, 2021

#1225 bugfix for jumping Select component borders

@ti10le ti10le closed this as completed Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready Ready for development type:design design type:feature New feature or component
Projects
None yet
Development

No branches or pull requests

3 participants