Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(comp): add defaultSelected and disabledKeys prop to Select #1216

Merged
merged 19 commits into from
Aug 20, 2021
Merged

feat(comp): add defaultSelected and disabledKeys prop to Select #1216

merged 19 commits into from
Aug 20, 2021

Conversation

ti10le
Copy link
Contributor

@ti10le ti10le commented Aug 16, 2021

sebald and others added 14 commits July 2, 2021 10:54
@sebald
chore(jest): Update jest to version 27
ffa77ec 
We no longer use tsdx to run our tests, since it wasn't update over 8 months ...
@ti10le
Merge branch 'jest-major-update-to-27' into main
7f85798
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
0ed336b
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
3a04338
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
a643b95
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
6fb96ef
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
9170315
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
d2d4e30
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
27c0cad
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
9998892
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into main
80f93ab
@ti10le
wip selectedItem and disabledItem
3ff4ab7
@ti10le
Merge branch 'main' of https://github.com/marigold-ui/marigold into s…
8ee8356 
…elect-option-item-feature
@ti10le
fix select mdx file
5ccdcc4
@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 70390c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:feature New feature or component labels Aug 16, 2021
@coveralls
Copy link

coveralls commented Aug 16, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 70390c1 on select-option-item-feature into eaeb745 on main.

@ti10le ti10le marked this pull request as draft August 16, 2021 07:16
@ti10le ti10le marked this pull request as ready for review August 16, 2021 07:27
@viktoria-schwarz viktoria-schwarz changed the title Add defaultSelected and disabledKeys prop to <Select> feat(comp): add defaultSelected and disabledKeys prop to Select Aug 20, 2021
@viktoria-schwarz viktoria-schwarz merged commit bdbe756 into main Aug 20, 2021
@viktoria-schwarz viktoria-schwarz deleted the select-option-item-feature branch August 20, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktoria-schwarz viktoria-schwarz viktoria-schwarz approved these changes

Assignees
No one assigned
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti10le @coveralls @viktoria-schwarz @sebald