Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): Make <Text> and <Link> polymorphic #1132

Merged
merged 12 commits into from
Jun 22, 2021
Merged

Conversation

sebald
Copy link
Member

@sebald sebald commented Jun 22, 2021

  • <Text>

    • the as prop supports arbitrary inputs
    • supporst ref
    • supports style props (text-align, color, cursor, user-select)
  • <Link>

    • the as prop supports arbitrary inputs
    • does not support ref!
    • improved accessibility (react-aria)

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2021

🦋 Changeset detected

Latest commit: ebc5851

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@marigold/components Patch
@marigold/types Patch
docs Patch
@marigold/icons Patch
@marigold/theme-b2b Patch
@marigold/theme-unicorn Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the type:feature New feature or component label Jun 22, 2021
@coveralls
Copy link

coveralls commented Jun 22, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling ebc5851 on text-link-update into 0313787 on main.

sebald added 3 commits June 22, 2021 11:07
* main:
  feat(types): Clarify and improve as prop related types (#1131)
  chore(prettier): add ignore patterns for prettier (#1130)
  chore: fix new yarn build (#1128)
  chore: update setup in readme (#1127)
  bugfix: give children to inlineCode (#1126)
@sebald sebald changed the title feat(compoents): Make <Text> and `<Link> polymorphic feat(components): Make <Text> and `<Link> polymorphic Jun 22, 2021
@sebald sebald changed the title feat(components): Make <Text> and `<Link> polymorphic feat(components): Make <Text> and <Link> polymorphic Jun 22, 2021
@sebald sebald marked this pull request as ready for review June 22, 2021 09:13
ti10le
ti10le previously approved these changes Jun 22, 2021
packages/components/src/Text/Text.tsx Show resolved Hide resolved
sebald added 2 commits June 22, 2021 13:28
* main:
  chore(gh-actions): add new, sorted actions with caching (#1129)
@vercel
Copy link

vercel bot commented Jun 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mrgld/marigold/2gxnL8edR7QEsx6jtu1k8c3AnqSz
✅ Preview: https://marigold-git-text-link-update-mrgld.vercel.app

@vercel vercel bot temporarily deployed to Preview June 22, 2021 11:52 Inactive
@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Jun 22, 2021
@sebald sebald merged commit b6614f1 into main Jun 22, 2021
@sebald sebald deleted the text-link-update branch June 22, 2021 12:11
sebald added a commit that referenced this pull request Jun 22, 2021
* main:
  feat(components): Make `<Text>` and `<Link>` polymorphic (#1132)
  chore(gh-actions): add new, sorted actions with caching (#1129)
  feat(types): Clarify and improve as prop related types (#1131)
  chore(prettier): add ignore patterns for prettier (#1130)
  chore: fix new yarn build (#1128)
  chore: update setup in readme (#1127)
  bugfix: give children to inlineCode (#1126)
  chore(deps): update all (#1120)
  fix(deps): update dependency @theme-ui/css to v0.10.1 (#1123)
  fix(deps): update typescript-eslint monorepo to v4.27.0 (#1121)
  fix(deps): update dependency gatsby to v3.7.2 (#1119)
  chore(deps): pin dependency @types/mdx-js__react to 1.5.3 (#1118)
  docs: Unify Gatsby's element wrapper (#1117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants