Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add normalization for body and html & fix emotion leak #1515

Merged
merged 7 commits into from
Dec 6, 2021
Merged

feat: add normalization for body and html & fix emotion leak #1515

merged 7 commits into from
Dec 6, 2021

Conversation

sebald
Copy link
Member

@sebald sebald commented Dec 3, 2021 •
edited
Loading

  • Remove emotion import form components so that it doesn't leak outside system package

@sebald
feat: add normalization for body and html
1e02a60 
... so not every theme has to do it :D
@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 9058aab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@marigold/components Patch
@marigold/system Patch
docs Patch
@marigold/theme-b2b Patch
@marigold/theme-core Patch
@marigold/theme-unicorn Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the type:feature New feature or component label Dec 3, 2021
@coveralls
Copy link

coveralls commented Dec 3, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9058aab on normalize-html-body into 5107b94 on main.

@sebald sebald marked this pull request as draft December 3, 2021 12:50
@sebald sebald changed the title feat: add normalization for body and html feat: add normalization for body and html & fix emotion leak Dec 3, 2021
@sebald
Copy link
Member Author

sebald commented Dec 3, 2021

Note: This will only work after #1514 is merged

@sebald sebald marked this pull request as ready for review December 3, 2021 15:58
sebald added 4 commits December 3, 2021 22:38
@sebald
Merge branch 'main' into normalize-html-body
87f13fe 
* main:
  feat(system): Use emotion's context (#1514)
  fix(docs): DoAndDont component (#1512)
@sebald
ups
83d8a37
@sebald
test!
ff22901
@sebald
changelog
9058aab
@ti10le ti10le merged commit 8eda245 into main Dec 6, 2021
@ti10le ti10le deleted the normalize-html-body branch December 6, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti10le ti10le ti10le approved these changes

Assignees
No one assigned
Labels
type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebald @coveralls @ti10le