Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(comp): new colors for radio, checkbox, slider #1568

Merged
merged 4 commits into from
Dec 17, 2021
Merged

feat(comp): new colors for radio, checkbox, slider #1568

merged 4 commits into from
Dec 17, 2021

Conversation

ti10le
Copy link
Contributor

@ti10le ti10le commented Dec 16, 2021

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: c76e252

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:feature New feature or component labels Dec 16, 2021
@coveralls
Copy link

coveralls commented Dec 16, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-1.1%) to 98.884% when pulling c76e252 on use-new-colors into 993efdb on main.

@ti10le ti10le marked this pull request as draft December 16, 2021 09:27
@github-actions github-actions bot removed the type:docs Improvements or additions to documentation label Dec 16, 2021
@ti10le ti10le marked this pull request as ready for review December 16, 2021 10:54
sebald
sebald requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@sebald sebald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use theme-ui!

themes/theme-b2b/src/index.ts Outdated Show resolved Hide resolved
@ti10le
Copy link
Contributor Author

ti10le commented Dec 17, 2021

Use theme-ui!

in one of my next PRs (theme-refactoring) I'll use this instead of all "colors. blue.."

sebald
sebald requested changes Dec 17, 2021
View reviewed changes
themes/theme-unicorn/src/index.ts Outdated Show resolved Hide resolved
@sebald sebald merged commit 8d24e87 into main Dec 17, 2021
@sebald sebald deleted the use-new-colors branch December 17, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebald sebald sebald approved these changes

Assignees
No one assigned
Labels
type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti10le @coveralls @sebald