Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refa: Redo <Field> now called <TextField> #1937

Merged
merged 16 commits into from
Apr 1, 2022
Merged

refa: Redo <Field> now called <TextField> #1937

merged 16 commits into from
Apr 1, 2022

Conversation

sebald
Copy link
Member

@sebald sebald commented Mar 31, 2022 •
edited
Loading

  • correctly passes down type
  • supports help text and error message
  • supports validation state
  • correct prop types
  • supports current styling

sebald added 13 commits March 28, 2022 12:30
@sebald
move stuff
31deae1
@sebald
what am I even doing
46aabcd
@sebald
Merge branch 'main' into new-text-field
7d2e93a 
* main:
  feat(comp): Container with grid (#1926)
  chore: make storybook faster (#1924)
@sebald
make them tests work
0b184af
@sebald
move stuff
8a1b8ae
@sebald
move stuff
c8dbbe5
@sebald
woopsies
487413c
@sebald
Merge branch 'update-helptext' into new-text-field
3a0147e 
* update-helptext:
  woopsies
  move stuff
@sebald
yay
5a409f4
@sebald
Merge branch 'main' into new-text-field
2832764 
* main:
  test: add missing responsive sizing test
  docs: fix outline links styles (#1933)
  fix(system): support "number strings" as sizes
  feat(comp): Center component (#1870)
  feat(comp): Introduce Breakout component (#1930)
  fix: coverage to one hundred percent (#1932)
  feat: load google font in storybook (#1931)
  feat: Introduce redone <Field> (#1929)
  feat(comp): improve Container component (#1928)
  refa: improvement to`<HelpText>` API (#1927)
@sebald
working!
e2698fd
@sebald
add some tests
50696fc
@sebald
finish tests
f26603d
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 0bbdd3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@marigold/components Minor
@marigold/theme-b2b Major
@marigold/storybook-config Patch
@marigold/docs Patch
@marigold/theme-core Major
@marigold/theme-unicorn Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the type:feature New feature or component label Mar 31, 2022
@sebald
Copy link
Member Author

sebald commented Mar 31, 2022

Will replace the old Field with this in an extra PR after this gets merged :)

@sebald sebald requested a review from ti10le April 1, 2022 10:14
@ti10le ti10le merged commit a1f4796 into main Apr 1, 2022
@ti10le ti10le deleted the new-text-field branch April 1, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti10le ti10le ti10le approved these changes

Assignees
No one assigned
Labels
type:feature New feature or component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebald @ti10le