Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refa <Input> and <Input.Field> components and support icons #2824

Merged
merged 9 commits into from
Feb 27, 2023

Conversation

sarahgm
Copy link
Member

@sarahgm sarahgm commented Feb 27, 2023

  • old <Input> is now <Input.Field>
  • New <Input> is a wrapper for the <Input.Field>
  • add possibility for icons to the <Input>
  • styles are now passed to the <Input> not the <Input.Field>

closes #2818

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2023

🦋 Changeset detected

Latest commit: 1093d32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@marigold/docs Minor
@marigold/components Minor
@marigold/storybook-config Patch
@marigold/theme-b2b Major
@marigold/theme-core Major
@marigold/theme-unicorn Major
@marigold/system Minor
@marigold/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added type:docs Improvements or additions to documentation type:feature New feature or component labels Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #2824 (1093d32) into main (de69c7a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2824   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       104    +1     
  Lines         1102      1110    +8     
  Branches       161       162    +1     
=========================================
+ Hits          1102      1110    +8     
Impacted Files Coverage Δ
...ackages/components/src/NumberField/NumberField.tsx 100.00% <ø> (ø)
packages/components/src/Input/Input.tsx 100.00% <100.00%> (ø)
packages/components/src/Input/InputField.tsx 100.00% <100.00%> (ø)
packages/components/src/TextField/TextField.tsx 100.00% <100.00%> (ø)

@sarahgm sarahgm changed the title chore: refa <Input> and <Input.Field> components chore: refa <Input> and <Input.Field> components and support icons Feb 27, 2023
sebald
sebald previously approved these changes Feb 27, 2023
.changeset/healthy-dancers-explode.md Outdated Show resolved Hide resolved
@sebald sebald merged commit 33329ac into main Feb 27, 2023
@sebald sebald deleted the icon-input branch February 27, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Improvements or additions to documentation type:feature New feature or component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add leading icon and trailing button support to <Input/>
2 participants